This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 170019 - AWT thread blocked for 29537 ms.
Summary: AWT thread blocked for 29537 ms.
Status: RESOLVED DUPLICATE of bug 170853
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL: http://statistics.netbeans.org/except...
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-07 06:36 UTC by Exceptions Reporter
Modified: 2009-09-07 07:31 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter: 155174


Attachments
nps snapshot (12.99 KB, bin/nps)
2009-08-07 06:36 UTC, Exceptions Reporter
Details
partial patch proposal (10.60 KB, patch)
2009-08-07 09:26 UTC, Ondrej Vrabec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Exceptions Reporter 2009-08-07 06:36:36 UTC
Build: NetBeans IDE Dev (Build 090807)
VM: Java HotSpot(TM) Client VM, 14.0-b16, Java(TM) SE Runtime Environment, 1.6.0_14-b08
OS: Windows Vista, 6.0, x86
Maximum slowness yet reported was 29537 ms, average is 29537
Comment 1 Exceptions Reporter 2009-08-07 06:36:41 UTC
Created attachment 85936 [details]
nps snapshot
Comment 2 Ondrej Vrabec 2009-08-07 08:20:46 UTC
getAllModifiedFiles all over again. But this time it's finally in enable() method of a subversion action (this time
commit action specifically). I guess it's time to re-thing our strategy of evaluating actions' enable/disable status.

I suggest:
1) First check if the context is managed: if not, then don't bother evaluating the context further. Should be fast
enough and achieved by calling super.enable().
2) Modify cache.listFiles() method in a similar way as cache.getCachedModifiedFiles was. listFiles should not scan
modified files and return their cached values as soon as possible and notify a caller that returned values are not accurate.
3) if cache.listFiles returns only a subset of CACHED modified files (real modified files need to be scanned) than
always ENABLE the action. Otherwise enable/disable the action depending on returned values
4) In performAction ALWAYS use the same algorithm as in enable method

tomas: any ideas?
Comment 3 Ondrej Vrabec 2009-08-07 09:26:29 UTC
Created attachment 85949 [details]
partial patch proposal
Comment 4 Ondrej Vrabec 2009-08-07 09:27:31 UTC
Maybe something like my uploaded patch?
Comment 5 Ondrej Vrabec 2009-09-07 07:31:02 UTC
fixed in the scope of issue 170853

*** This issue has been marked as a duplicate of 170853 ***