This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 194165 - FeedReader Sample Needs Refactoring
Summary: FeedReader Sample Needs Refactoring
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Templates (show other bugs)
Version: 7.0
Hardware: PC Linux
: P2 normal (vote)
Assignee: Geertjan Wielenga
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-09 21:07 UTC by Geertjan Wielenga
Modified: 2011-01-13 07:47 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Patch that refactors the FeedReader sample (42.07 KB, patch)
2011-01-09 21:36 UTC, Geertjan Wielenga 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geertjan Wielenga 2011-01-09 21:07:56 UTC 
The FeedReader sample has a file of 203 lines, or maybe 302, can't remember. That's really not working in the tutorial, which should be the same as the sample that we provide. I am going to break up that file into smaller files and package them into smaller packages.
Comment 1 Geertjan Wielenga 2011-01-09 21:36:39 UTC 
Created attachment 104829 [details]
Patch that refactors the FeedReader sample
Comment 2 Geertjan Wielenga 2011-01-09 21:37:51 UTC 
Patch is attached. Jarda can you verify and integrate? Or pass to Jesse?
Comment 3 Jaroslav Tulach 2011-01-10 09:39:13 UTC 
If you think, this is proper refactory, feel free to integrate it.
Comment 4 Jesse Glick 2011-01-12 16:17:14 UTC 
If the app still works, it's probably OK.
Comment 5 Geertjan Wielenga 2011-01-12 16:19:52 UTC 
Could one of you commit it? Password problems with my account won't let me do that at the moment.
Comment 6 Jesse Glick 2011-01-12 17:42:02 UTC 
(In reply to comment #5)
> Could one of you commit it?

core-main #2d8a40a6ee2f

> Password problems with my account won't let me do that at

Not true. You can always commit - you just might not be able to push. Better to commit, then use 'hg bundle' to send your changeset(s) to someone who can push them.
Comment 7 Quality Engineering 2011-01-13 07:47:42 UTC 
Integrated into 'main-golden', will be available in build *201101130001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/2d8a40a6ee2f
User: geertjan@netbeans.org
Log: #194165: FeedReader Sample Needs Refactoring