This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Right now plugin verification does not require any comment when voting NoGo. This is however very unfortunate, because if a plugin verifier disapproves publishing on the Update Center without providing any justification, it's very confusing for the plugin's owner to fix the problem. Therefore it would be great to: 1. Disable "Vote" button if "No Go" checkbox is checked and "Comment" field is empty. Plus display "Your justification for NoGo verdict is required." message in red. 2. Automatically file a bug for tracking purpose with the following details: Product: updatecenters Component: Pluginportal Version: <verification_version> Priority: P3 Issue Type: DEFECT Summary: NoGo for plugin <plugin_name> Assignee: <plugin_owner> Reporter: <plugin_verifier> Description: <justification_from_plugin_verifier> This bug would be then linked from "Verification details" popup window.
Part 1) is now implemented. Though it's not done exactly as you suggested with javascript. Instead there is server side check on POST and submission is not accepted in such case and error message displayed.
Excellent. This solution to part #1 is satisfactory.
both parts are now implemented and deployed, PP and BZ are crosslinked for easy navigation
First of all thanks Honzo for such a quick turnaround. It works great but I have two comments so reopening this to get your feedback: 1. The bug gets created correctly but it's assigned to plugin verifier instead of plugin owner who should in fact resolve the problem described by verifier. 2. Would it be possible to make the bug ID a clickable link in "Verification details" popup window?
Hello, add 1) This is now done. add 2) This is not going to be, as there is very strict filter set for all the user output, which this is part of and it clears all html. Security first.
Wonderful. Thank you - verifying.
There is still one minor issue that each NoGo creates its own issue. It would be nice if 2nd, 3rd ... NoGo just adds justification as a comment to the original issue. For example, if first person votes NoGo, issues is created and Plugin Portal would record its ID. If another verifiers votes NoGo, Plugin Portal would just add his NoGo justification to the issue created when the first verifier blocked the request. This way Bugzilla would not be polluted by duplicates and it would also save some time when searching the original bug report and marking it as a duplicate.
comments on consequent nogos implemented