This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231566 - Platform download support excludes to much modules
Summary: Platform download support excludes to much modules
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Harness (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P2 normal (vote)
Assignee: Martin Kozeny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 12:13 UTC by fvogler
Modified: 2013-06-27 02:19 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Suite project (13.47 KB, application/zip)
2013-06-25 17:51 UTC, fvogler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description fvogler 2013-06-20 12:13:49 UTC
Hi,

I have a suite project using the download feature.

platform.properties:
>>>
bootstrap.url=http://updates.netbeans.org/netbeans/updates/7.3/uc/final/distribution/tasks.jar
autoupdate.catalog.url=http://updates.netbeans.org/netbeans/updates/7.3/uc/final/distribution/catalog.xml.gz

nbplatform.active=download
nbplatform.download.netbeans.dest.dir=${suite.dir}/nb73
nbplatform.download.harness.dir=${nbplatform.download.netbeans.dest.dir}/harness
...
<<<

Excluding 'org.netbeans.modules.projectui' (disabled.modules) excludes 'org.netbeans.modules.projectuiapi' as well.

This is caused by an insufficient regular expression in platform.xml
(<pathconvert property="module.includes" pathsep="">)
line 20:
Is:    <mapper type="glob" from="${basedir}${file.separator}*" to="(?!\Q*\E)"/>
Fixed: <mapper type="glob" from="${basedir}${file.separator}*" to="(?!^\Q*\E$)"/>

Regex is used in org.netbeans.nbbuild.AutoUpdate:505 to check a module codenamebase.

Regards
Florian
Comment 1 Martin Kozeny 2013-06-24 12:33:07 UTC
Hi Florian, 

I've tried to create suite, than update platform.properties according to your suggestion. After that I exclude module 'org.netbeans.modules.projectui', but after invoking AutoUpdate from platform.xml, list of disabled modules remain unchanged. Could you please attach your sample project for reproducing?
Comment 2 fvogler 2013-06-25 17:51:58 UTC
Created attachment 136287 [details]
Suite project

Suite project with missing module error.
Modified for easier testing:
build.xml deletes platform dir first to enforce platform download/recreation

Fix (regex) is in platform.xml line 21 as comment.
Comment 3 fvogler 2013-06-25 18:00:54 UTC
Hi Martin,

steps to error:
1) suite project (using bootstrap) with module depend on
   org.netbeans.modules.projectuiapi
2) build suite -> download full clusters (ide|platform)
3) open suite project editor, disable all modules and then click resolve
4) delete platform and build again
Comment 4 Martin Kozeny 2013-06-26 13:55:05 UTC
You are right Florian. Thank you for your fix.
https://hg.netbeans.org/core-main/rev/ca4ee62b4eca
Comment 5 Quality Engineering 2013-06-27 02:19:48 UTC
Integrated into 'main-golden', will be available in build *201306262301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/ca4ee62b4eca
User: Martin Kozeny <mkozeny@netbeans.org>
Log: #231566: Changing the regexp declared in platform file for matching cnbs  used in AutoUpdate class.