This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
The current implementation of the browser picker doesn't match the spec in terms of proposed labels. This is important because, as currently implemented, it isn't clear that everything in the "with nb integration" band actually has nb integration. Here's the email I sent to Petr about this: > Guys: > > The new browser picker still doesn't use the labels called for in the spec (attached). I'm fairly certain I've mentioned this in bugs related to this before, but it's tricky with multiple owners for different parts of the feature. We also need to show a more complete label in the tooltip than what we show here. Finally, the Run menu options should probably share the same descriptive label as the toolbar. > > Do we want to fix this? As it stands now, we don't match the design and I'm not sure we're giving good feedback to the user. For example, in the browser picker, the fact that we have one item "with NetBeans Integration" suggests the others don't have it. > > Please let me know if you want me to log a new bug consolidating this info for one owner. > > Thanks! > Liza
Created attachment 139846 [details] example labels for browser picker
Aha, it seems that this issue wasn't reassigned to me accidentally ;) Do I understaned it correctly that "with NetBeans integration" should be removed? Or anything more? Thanks.
Davide, I don't know these modules well but I can see 2 possiblities here: (a) add a new method, e.g. getSimpleDsiplayName(); or (b) work around it in the popup only (by ugly replacing part of the string). I prefer the (a) option, of course. Moreover, a new method for a tooltip will be needed (getShortDescription()?). Let me know what you think about it and feel free to reassign back to me, I will do it. Thanks.
Just one note - HTML5 project type uses ordinary combo for browser selection and not the picker - so we still must be able to somehow say which browser has NetBeans integration and which does not.
Could we drop "with NetBeans integration" from browser name completely? And in cases where browser names would be ambiguous could we customize browser name? There is .hasNetBeansIntegration() method I think somewhere which should help.
I will do that.
Should be fixed now, proper browser name should be present: - in the picker, - in the tooltip of the toolbar icon, - in the "ordinary" combo in the Project Properties dialog. Please, could anyone verify it for mobile browsers on all platforms as well? I was not sure about PHONEGAP browser family ID... Honzo? BTW not sure whether this is a candidate for NB 7.4. Thanks. http://hg.netbeans.org/web-main/rev/7ab89003586f
I think it make sense to push it to 7.4 because it is so prominenly visible. My two cents.
Petře, what do you think? Also, Honzo, is this change OK for you (I mean PHONEGAP as I wrote)? Thanks.
Sorry, I forgot to respond yesterday. In principle I agree, let's put it in 7.4. But in the current state there are still some inconsistencies: - Some of the items in the "With NetBeans Connector" section of the picker contain the "with NetBeans Integration" distinction in the tooltip + combo in project properties, while others don't. Should the items from the "Mobile Device Browser" section also include "with NetBeans Integration" in the tooltip, to make this consistent with the Cordova section? - I am still torn about the term Connector vs. Integration. The section in the picker is labeled as "With NetBeans Connector", but in other places we use Integration. And only for Chrome, we actually have a real artifact called "NetBeans Connector"; for the other browsers, it is an abstract term. Maybe we should just ignore this distinction and change it to Connector everywhere - I must say Connector sounds better to me than Integration. This could have impact on UI/docs though - cc'ing Ken.
OK, I will improve the change: - "Connector" everywhere in the code; - "with NetBeans Connector" for mobile browsers as well (but NOT for embedded browser). Thanks.
Done. Láďo, please verify, I will transplant it to NB 7.4. Thanks. http://hg.netbeans.org/web-main/rev/1e4c6d232881
BTW (In reply to Tomas Mysik from comment #11) > - "Connector" everywhere in the code; I used grep to replace it really everywhere.
Verified in web-main, browser picker and project properties show Connector Product Version: NetBeans IDE Dev (Build web-main-11600-on-20130913) Java: 1.7.0_40; Java HotSpot(TM) Client VM 24.0-b56 Runtime: Java(TM) SE Runtime Environment 1.7.0_40-b43 System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)
I reviewed the changes and they look good.
Transplanted to releases repo, branch release74. The original fix increases spec version but I did not change it in the release74 since it is already properly set (to x.y.1). I have build full IDE without any problem, if anyone sees any problem with it, please, fix it. Thanks. http://hg.netbeans.org/releases/rev/17ee398d1db1 http://hg.netbeans.org/releases/rev/964df53bce25
Integrated into 'main-silver', will be available in build *201309140002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/1e4c6d232881 User: Tomas Mysik <tmysik@netbeans.org> Log: #235711 cont'd - New browser picker implementation doesn't match spec for labels Replacing "integration" with "Connector" everywhere.
Verified in RC1 Product Version: NetBeans IDE 7.4 RC1 (Build 201309152201) Java: 1.8.0-ea; Java HotSpot(TM) Client VM 25.0-b49 Runtime: Java(TM) SE Runtime Environment 1.8.0-ea-b107 System: Linux version 3.2.0-48-generic-pae running on i386; UTF-8; en_US (nb)