This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 243044 - Graphical diff should not be possible for binary files in (local) history
Summary: Graphical diff should not be possible for binary files in (local) history
Status: NEW
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Localhistory (show other bugs)
Version: 8.0
Hardware: PC Mac OS X
: P4 normal (vote)
Assignee: Tomas Stupka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-19 10:28 UTC by host
Modified: 2014-03-21 09:05 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description host 2014-03-19 10:28:12 UTC 
I have a PostgreSQL database dump file versioned in my SVN repository. Now I select "History" > "Show History" for that file and the list of all changes is shown. Now, if I select/click on an entry in the list then the graphical diff of the current version of that file vs. a previous one is shown. BUT since the dump file is binary such a diff is not really sensible (I think). 

Therefore (I think again) the automatic diffing for binary files should either be disabled completely or one should get a warning as it happens when you try to open the file in NetBeans: "Binary File Detected: This file appears to contain binary data. Are you sure you want to open it in the text editor?"
Comment 1 Ondrej Vrabec 2014-03-21 09:05:30 UTC 
Local history should check if the content is binary before displaying it. Likely the same as org.netbeans.modules.git.utils.GitUtils.getMimeType()