This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Please add to manifest a line that restricts access to non-public packages of autoupdate module. See http://www.netbeans.org/download/apis/org/openide/doc-files/upgrade.html#3.4-public-packages This might not be an easy task as the default package seems to contain some api classes: AutoUpdateType, etc. This this issue is likely blocked by issue 19930
Defect, or task?
I believe that this is a stopper for any version that wants Arch review. As we do not want that for 3.5 I have filled it with target version 4.0. So I am not looking for quick fix, I just want a fix for next version.
I don't think this is a defect, exactly - no known problem with running the app caused by it.
This issue has been fired as part of Arch review and indicates something that should be fixed if we want to fullfil the arch. That is why this is defect p2 priority, but as the Arch was not goal for 3.5, it is fired just for 4.0 version - it is not a defect for 3.5, just for 4.0.
reassigne to Jirka - new owner of autoupdate
It's not a defect which bloks any NB3.6 funcionality. It's targeted to Promo D (Cat-7: ARC - must pass ARC review).
Waiver approved.
Depends on issue 19930 which is targeted to future for now.
Disagree with evaluation. For now, no other modules should be referring to any packages in autoupdate.jar. Therefore it should list OpenIDE-Module-Public-Packages: - If and when it gets an API, it can specify its API packages there. Don't see how status of issue #19930 blocks this.
Almost fixed, useless public classes has been restrict to package-private. Autoupdate now publish only the classes which are used out of autoupdate module (e.g. XMLAutoupdateType extends out NB sources). Now only needs add description to module's javadoc, generate javadoc in nbbuild/build.xml, specify api in arch document.
IMHO it is probably not necessary to include Javadoc for the module; you could, but better not to list it in nbbuild/build.properties, since it is in no way official. However it is definitely a good idea to mention in the arch document that this one class is public as a "friend API" and who is expected to use it.
delayed after UI freeze
no user visible effect, lowered priority to P3. We may or may not fix it for Promo D
I guess this won't be fixed for NB4.0 , please evaluate again.
Because of stop of extending of Autoupdate's public packages AFAIK we shouldn't expose any Autoupdate's packages. I'm going to remove org.netbeans.modules.autoupdate from the public packages folder in project metadata. Should be tracked as API_REVIEW_FAST.
Due to objections of a team which builds on the top of current Autoupdate and finalization of releases on both teams I postpone this to next release to avoid any unwanted problems.
Can't we at least use <friend-packages> so only that team would be permitted to use these packages in 5.0?
Created attachment 27574 [details] part of patch
I currently don't know all packages which wants be acting as friend in NB5.0. I'll apply this patch after create release50 branch.
Checking in autoupdate/manifest.mf; /shared/data/ccvs/repository/autoupdate/manifest.mf,v <-- manifest.mf new revision: 1.62; previous revision: 1.61 done Checking in autoupdate/arch/arch-autoupdate.xml; /shared/data/ccvs/repository/autoupdate/arch/arch-autoupdate.xml,v <-- arch-autoupdate.xml new revision: 1.36; previous revision: 1.35 done Checking in autoupdate/nbproject/project.xml; /shared/data/ccvs/repository/autoupdate/nbproject/project.xml,v <-- project.xml new revision: 1.25; previous revision: 1.24 done Checking in autoupdate/src/org/netbeans/modules/autoupdate/Autoupdater.java; /shared/data/ccvs/repository/autoupdate/src/org/netbeans/modules/autoupdate/Autoupdater.java,v <-- Autoupdater.java new revision: 1.62; previous revision: 1.61 done Checking in ide/golden/cluster-deps.txt; /shared/data/ccvs/repository/ide/golden/cluster-deps.txt,v <-- cluster-deps.txt new revision: 1.64; previous revision: 1.63 done Checking in ide/golden/deps.txt; /shared/data/ccvs/repository/ide/golden/deps.txt,v <-- deps.txt new revision: 1.379; previous revision: 1.378 done Checking in ide/golden/friend-packages.txt; /shared/data/ccvs/repository/ide/golden/friend-packages.txt,v <-- friend-packages.txt new revision: 1.58; previous revision: 1.57 done Checking in ide/golden/public-packages.txt; /shared/data/ccvs/repository/ide/golden/public-packages.txt,v <-- public-packages.txt new revision: 1.75; previous revision: 1.74 done Checking in ide/welcome/nbproject/project.xml; /shared/data/ccvs/repository/ide/welcome/nbproject/project.xml,v <-- project.xml new revision: 1.10; previous revision: 1.9 done Checking in ide/welcome/src/org/netbeans/modules/welcome/ui/ArticlesAndNews.java; /shared/data/ccvs/repository/ide/welcome/src/org/netbeans/modules/welcome/ui/ArticlesAndNews.java,v <-- ArticlesAndNews.java new revision: 1.14; previous revision: 1.13 done Checking in editor/options/nbproject/project.xml; /shared/data/ccvs/repository/editor/options/nbproject/project.xml,v <-- project.xml new revision: 1.17; previous revision: 1.16 done Checking in editor/options/src/org/netbeans/modules/options/general/GeneralOptionsModel.java; /shared/data/ccvs/repository/editor/options/src/org/netbeans/modules/options/general/GeneralOptionsModel.java,v <-- GeneralOptionsModel.java new revision: 1.8; previous revision: 1.7 done