This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 31743 - The 'Local Registry' menu item on RMI Registry node is disabled.
Summary: The 'Local Registry' menu item on RMI Registry node is disabled.
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: rmi (show other bugs)
Version: -S1S-
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: Jan Kovar
URL:
Keywords: REGRESSION
Depends on: 32467
Blocks:
  Show dependency tree
 
Reported: 2003-03-06 13:54 UTC by Marek Fukala
Modified: 2003-04-02 12:01 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
The NoClassDefFoundError. (384 bytes, text/plain)
2003-03-06 14:00 UTC, Marek Fukala
Details
rmi.jar for [nevada] and [release35] branches (831.15 KB, application/octet-stream)
2003-03-26 15:14 UTC, Jan Kovar
Details
Diff (837 bytes, patch)
2003-03-27 09:36 UTC, Jan Kovar
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Fukala 2003-03-06 13:54:53 UTC
[S1S #030304_1 jdk1.4.1_02-b06]
The 'Local Registry' menu item on RMI Registry
node is disabled even if there is no running
registry on the default port.
Comment 1 Marek Fukala 2003-03-06 14:00:18 UTC
Created attachment 9292 [details]
The NoClassDefFoundError.
Comment 2 Marek Fukala 2003-03-06 14:02:06 UTC
The attached file is not for this bug! It's my mistake.
Comment 3 Jan Kovar 2003-03-26 14:44:12 UTC
Raising priority to P1 as the bug is regression and without fix one 
RMI feature is not usable at all.
Comment 4 Jan Kovar 2003-03-26 15:10:55 UTC
Fixed in [maintrunk].

I will also provide jar file for [nevada]/[release35] 
branches.

Marek, could you please verify it?
Comment 5 Jan Kovar 2003-03-26 15:14:04 UTC
Created attachment 9538 [details]
rmi.jar for [nevada] and [release35] branches
Comment 6 Jan Kovar 2003-03-27 09:36:14 UTC
Created attachment 9554 [details]
Diff
Comment 7 Jan Kovar 2003-03-27 09:37:20 UTC
Tomas, could you please review the fix?

Thanks.
Comment 8 Jan Kovar 2003-03-27 09:45:28 UTC
Short description of the fix:
The bug is caused by changes in the openide module. 
However its probably easier to fix it within RMI module 
itself (although it does not solve the root cause of the 
problem).
The issue is, that the LocalRegistryAction is having mode 
MODE_EXACTLY_ONE which means, that only exactly one node 
(and the one which is relevant for this action) must be 
selected to activate this action. However after changes 
in the openide module when selecting proper node (RMI 
Registry node in runtime) two nodes are always returned as 
active nodes: node itself and relevant filter node and 
therefore the action is always disabled.
The easiest way to fix it is to change mode of the action 
from MODE_EXACTLY_ONE to MODE_ALL which will make the 
action enabled only when all activated nodes are relevant. 
And as there is only one real node which is relevant it 
should always produce proper result.
Fix is very simple and should not have any negative impact 
on the RMI module or any other modules.
Comment 9 Tomas Zezula 2003-03-27 14:15:07 UTC
The patch seems fine.
It fixes the problem does not affect the other module (IDE) behaviour.
Comment 10 Marek Fukala 2003-03-27 16:24:33 UTC
Verified the bugfix in main trunk build #200303270100, with the
attached module jarfile in netbeans 3.5 build #200303262350 and S1S
Nevada build #030326.
Comment 11 _ ttran 2003-03-27 16:38:13 UTC
approved for release35 by release coordinator
Comment 12 Jesse Glick 2003-03-27 20:28:59 UTC
I'm not sure what changes in openide and what extra filter node you
are referring to, but if you have reason to believe there is some
regression in openide you had better file it (and make this issue
depend on it).

Looking at LocalRegistryAction, it is quite stupid - does not need to
be a CookieAction at all. Should be a CallableSystemAction. That would
be the better thing to do.
Comment 13 Jan Kovar 2003-03-28 08:39:25 UTC
Jesse, I agree with you that the fix is not ideal and also I will file 
a bug against openide, however:
1. After my fix the bug does not depend on a openide fix as it will 
work anyway
2. We are in High Resistance mode so I think that its better to fix 
the problem using easy fix then most correct one. IMHO less chance of 
regression.

Im closing it as fixed (its approved and also verified by QA). If you 
think that the action should be rewritten to be a 
CallableSystemAction, file new task. 
Comment 14 Jesse Glick 2003-03-28 15:42:51 UTC
OK, I filed #32467. Actually changing the superclass of the action
should be quite trivial as well.

BTW you forgot to set a target milestone on this issue.
Comment 15 Marek Fukala 2003-04-02 12:01:33 UTC
Verified in Nevada 030331 build.