This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 33410 - Refresh all title should be changed
Summary: Refresh all title should be changed
Status: VERIFIED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: All All
: P3 blocker (vote)
Assignee: mslama
URL:
Keywords: UI
Depends on:
Blocks: 31047
  Show dependency tree
 
Reported: 2003-05-06 02:54 UTC by Rochelle Raccah
Modified: 2008-12-22 20:48 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rochelle Raccah 2003-05-06 02:54:55 UTC 
I've noticed a new "Refresh All Filesystems" menu
in the right click for the Filesystems node in the
explorer.  Since it's in the Filesystems node's
menu, "Filesystems" is redundant.  Additionally,
to be consistent with Build All and Compile All, I
suggest naming it "Refresh All".
Comment 1 jrojcek 2003-06-11 11:20:04 UTC 
I agree. A contextual menu items should not name the context as it is
obvious from the node they are invoked on. So, the main menu item
should stay named "Refresh All Filesystems", but the contextual menu
item should be name "Refresh All"
Comment 2 mslama 2003-06-24 15:29:29 UTC 
Jesse you added this action if I remember correctly. Where is its bundle?
Comment 3 mslama 2003-06-24 15:39:43 UTC 
grep made it: LAB_refresh_all_filesystems in org/netbeans/core/actions
Comment 4 mslama 2003-06-24 16:39:29 UTC 
Fixed in main trunk.

Modified:
/cvs/core/src/org/netbeans/core/actions/Bundle.properties r.1.128
Comment 5 Jesse Glick 2003-06-24 17:08:54 UTC 
You just changed the title in the File menu too. Reread Jano's comment.

Hint: implement Presenter.Popup to use a special label "Refresh All",
and leave Action.NAME as "Refresh All Filesystems".
Comment 6 mslama 2003-06-25 10:41:05 UTC 
Ooops. Thanks. I will add new label to be used by popup presenter. I
tried:    /** Get a menu item that can present this action in a    
public JMenuItem getPopupPresenter() {
        JMenuItem item = new JMenuItem();
        String text =
NbBundle.getMessage(RefreshAllFilesystemsAction.class,
"LAB_refresh_all_filesystems_popup");
        Actions.connect(item, this, true);
        Actions.setMenuText(item, text, true); 
        return item;
    }

Unfortunately Actions.setMenuText() has NO effect. (I tried to call
after or before Actions.connect() but no success. It uses original
action label even if text variable contains truncated version of
action label. Any idea?
Comment 7 mslama 2003-06-25 10:55:32 UTC 
I could use JMenuItem methods directly:
  item.setAction(this);
  item.setText(Actions.cutAmpersand(text));
  item.setMnemonic(KeyEvent.VK_R);

Is this possible for popup menu?
Comment 8 Jesse Glick 2003-06-25 21:06:00 UTC 
Sure, just make the JMenuItem directly.
Comment 9 mslama 2003-08-19 15:27:55 UTC 
Fixed in main trunk 2003/06/27. I just forgot to mark issue here as FIXED.

Modified:
/cvs/core/src/org/netbeans/core/actions/RefreshAllFilesystemsAction.java
r.1.2
Comment 10 Marian Mirilovic 2003-09-05 10:10:12 UTC 
verified in [nb_dev](20030904)