This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 42154 - NbDocument.CustomToolbar implementation [complete-May-28]
Summary: NbDocument.CustomToolbar implementation [complete-May-28]
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
: 43846 (view as bug list)
Depends on: 42153
Blocks: 41190
  Show dependency tree
 
Reported: 2004-04-20 08:19 UTC by Milos Kleint
Modified: 2007-11-05 13:44 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Milos Kleint 2004-04-20 08:19:32 UTC
This is multiview module related. (branch
multiview_march2004)

In order to place the toolbar in the multiview
component, the current setup where the toolbar is
part of the editor component needs to be changed
and become part of the enclosing Component (eg.
CloneableEditor)

NbDocument.CustomToolbar interface was introduced
for this. The editor module shall provide it's
toolbar using this interface to the enclosing
component.
Comment 1 Milos Kleint 2004-05-04 10:09:24 UTC
core/multiview module (and whole branch multiview_march2004) was
merged to trunk.
Comment 2 David Simonek 2004-05-27 14:46:20 UTC
Can I ask what is expected completion date? We would like to mark
multiviews as feature complete and this is last issue that remains to
be implemented.
Please include your time estimations into summary field if possible.
Thanks.
Comment 3 Miloslav Metelka 2004-05-27 16:14:02 UTC
*** Issue 43846 has been marked as a duplicate of this issue. ***
Comment 4 Miloslav Metelka 2004-05-27 16:16:25 UTC
I'm working on this since this Tuesday (May 25) and I expect to have
it ready on this Friday (May 28).
Comment 5 Miloslav Metelka 2004-05-28 13:57:22 UTC
Implemented in trunk:

Checking in libsrc/org/netbeans/editor/EditorUI.java;
/cvs/editor/libsrc/org/netbeans/editor/EditorUI.java,v  <--  EditorUI.java
new revision: 1.63; previous revision: 1.62
done
Processing log script arguments...
More commits to come...
Checking in src/org/netbeans/modules/editor/NbEditorDocument.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorDocument.java,v 
<--  NbEditorDocument.java
new revision: 1.38; previous revision: 1.37
done
RCS file:
/cvs/editor/src/org/netbeans/modules/editor/NbEditorToolBar.java,v
done
Checking in src/org/netbeans/modules/editor/NbEditorToolBar.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorToolBar.java,v 
<--  NbEditorToolBar.java
initial revision: 1.1
done
Checking in src/org/netbeans/modules/editor/NbEditorUI.java;
/cvs/editor/src/org/netbeans/modules/editor/NbEditorUI.java,v  <-- 
NbEditorUI.java
new revision: 1.25; previous revision: 1.24
done
Removing src/org/netbeans/modules/editor/NbToolbarConfigNode.java;
/cvs/editor/src/org/netbeans/modules/editor/NbToolbarConfigNode.java,v
 <--  NbToolbarConfigNode.java
new revision: delete; previous revision: 1.4
done
Removing src/org/netbeans/modules/editor/NbToolbarSupport.java;
/cvs/editor/src/org/netbeans/modules/editor/NbToolbarSupport.java,v 
<--  NbToolbarSupport.java
new revision: delete; previous revision: 1.16

Will check whether meta_stavbicka is OK with this change.
Comment 6 Miloslav Metelka 2004-05-28 14:39:12 UTC
I've checked meta_stavbicka and it should work fine there except the
forms where the navigation view is disabled. However I have verified
that this issue existed even prior to integration of custom toolbar. I
have entered issue 43993 to track the problem.