This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 50149 - "Add Method" dialog is inconsistent with "Change Method Parameters" dialog
Summary: "Add Method" dialog is inconsistent with "Change Method Parameters" dialog
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jan Becicka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-08 08:50 UTC by jrojcek
Modified: 2007-09-26 09:14 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2004-10-08 08:50:39 UTC
Both dialogs should be more consistent. Especially:

* In "Add Method" dialog, there is "Access" combo, which is 
named "Visibility Modifier" in "Change Method Parameters" 
dialog.

* There is a Parameters list (with the Edit button)  "Add 
Method" dialog, but there is a Parameters table (with inplace 
editors) in "Change Method Parameters" dialog

You should also consider showing the Method Signature Preview 
in the Add Method dialog.
Comment 1 Martin Matula 2004-10-08 09:08:26 UTC
Pavle please consult with Dusan and fix it.
Comment 2 Pavel Flaska 2004-10-12 16:36:13 UTC
My personal opinions:
i) 'Access modifier' term is used by JLS, I prefered this name,
ii) parameters list is more appropriate even if we use table for
obtaining values from user,
iii) preview is tightly connected to 'Change Parameters' panel, but it
is simple to create similiar things for 'Add Method' dialog.
Comment 3 Pavel Flaska 2004-10-13 12:30:05 UTC
Dusan, what do you think?
Comment 4 dpavlica 2004-10-18 11:42:21 UTC
I agree with Pavel's i) and iii)
By ii) I would like to suggest to leave the table in Change method 
parameters dialog, because it's better for changing those three 
values by each parameter.
Comment 5 Jan Becicka 2005-02-25 09:47:40 UTC
Checking in Bundle.properties;
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.47; previous revision: 1.46
done

i) Visibility changed to Access
ii) and iii) left as it is.
Comment 6 Quality Engineering 2007-09-20 12:09:59 UTC
Reorganization of java component