This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 51862 - AIOOB from TreeView - CVS | Remove corrupts explorer state
Summary: AIOOB from TreeView - CVS | Remove corrupts explorer state
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Explorer (show other bugs)
Version: 4.x
Hardware: PC Windows XP
: P2 blocker (vote)
Assignee: Petr Nejedly
URL:
Keywords: RANDOM
: 51781 52389 52899 56538 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-11-26 00:02 UTC by _ gtzabari
Modified: 2008-12-22 23:37 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Exception stack-trace (1.38 KB, text/plain)
2004-12-02 16:15 UTC, _ gtzabari
Details

Note You need to log in before you can comment on or make changes to this bug.
Description _ gtzabari 2004-11-26 00:02:29 UTC
dev build 200411211900
JDK 1.5

Select 10-20 files in one-two directories, and
invoke CVS | Remove on them. Most of the time,
you'll get an IndexOutOfBoundsException, sometimes
you'll end up with two copies of the same file
showing up as "removed" in explorer, sometimes
entire subdirectories will disappear from explorer
-- all of this before a commit has even been invoked.

Something seems to be majorily broken with CVS |
Remove... Fortunately most of these bugs seem to
be cosmetic and restart Netbeans (as ugly as it
is) fixes the corrupt state of the explorer panel.
Comment 1 Martin Entlicher 2004-11-29 09:57:17 UTC
Occasionally, this happened to me as well. Can you please attach the
exception? In my opinion this is a fault of explorer...
Comment 2 Jan Chalupa 2004-11-30 18:48:30 UTC
Please don't blame explorer until you've analyzed the stack trace. The
bug apparently occurs while performing a VCS operation. The evaluation
should start in VCS then.
Comment 3 Martin Entlicher 2004-12-02 08:46:51 UTC
Gili, please attach the exception, so that we can evaluate this defect.
Thanks.
Comment 4 _ gtzabari 2004-12-02 16:15:08 UTC
Created attachment 19107 [details]
Exception stack-trace
Comment 5 Jan Chalupa 2004-12-02 16:46:16 UTC
Ok, it really looks like an explorer problem.
Comment 6 Petr Nejedly 2004-12-14 16:02:29 UTC
*** Issue 52389 has been marked as a duplicate of this issue. ***
Comment 7 Petr Nejedly 2005-01-05 15:18:03 UTC
*** Issue 52899 has been marked as a duplicate of this issue. ***
Comment 8 Petr Nejedly 2005-01-07 17:53:46 UTC
Probably related to issue 51781
Comment 9 Petr Nejedly 2005-03-16 14:38:41 UTC
*** Issue 56538 has been marked as a duplicate of this issue. ***
Comment 10 Petr Nejedly 2005-04-05 08:10:11 UTC
Seems like a combination of FilterNode problem with another problem in
explorer/visualizers. Can be quite often reproduced in NB-based products, so
raising priority.
Comment 11 Petr Nejedly 2005-04-07 10:08:44 UTC
Partially fixed:
openide/src/org/openide/explorer/view/VisualizerChildren.java,v1.16

The problem is with different nodes that are equals(), from now on, the explorer
should survive that situation if it can't fail properly, but usage of such nodes
is strongly discouraged.

Comment 12 Petr Nejedly 2005-04-07 10:16:18 UTC
*** Issue 51781 has been marked as a duplicate of this issue. ***
Comment 13 Petr Nejedly 2005-04-12 13:45:24 UTC
This issue itself is fixed. The additional issues that helped to trigger this
one were reported separately as issue 57768 and issue 57769. Marking this one as
FIXED.
Comment 15 Jaroslav Tulach 2005-04-13 08:35:55 UTC
Using == instead of equals is correct, that is what the
Visualizer.findVisualizer cache does as well. Your fix looks right?

Btw. where is the test to proof you are really fixing something? I thought you
had one, but there is no reference to in the bug report.
Comment 16 Petr Nejedly 2005-04-13 10:50:35 UTC
Sorry I forgot to mention the test. Sure there is one in the trunk:
http://www.netbeans.org/source/browse/openide/test/unit/src/org/openide/explorer/view/TreeView48993Test.java?r1=1.6&r2=1.7
Comment 17 Jaroslav Tulach 2005-04-13 14:28:52 UTC
Integrate to 4.1 then. Your patch provably fixes possible problem and I cannot
see how it would break something else.
Comment 18 Petr Nejedly 2005-04-13 14:55:39 UTC
Backported the fix:
/cvs/openide/src/org/openide/explorer/view/VisualizerChildren.java,v1.15.40.1

Comment 19 Tomas Danek 2005-07-15 11:30:15 UTC
removing works for me in 4.2 20050706, verified.