This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55754 - Cell height too small for checkbox
Summary: Cell height too small for checkbox
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Plugin Manager (show other bugs)
Version: 4.x
Hardware: Macintosh Mac OS X
: P3 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: UI
Depends on:
Blocks:
 
Reported: 2005-03-02 09:38 UTC by _ tboudreau
Modified: 2007-05-21 09:12 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Screen shot (14.82 KB, image/png)
2005-03-02 19:03 UTC, _ tboudreau 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description _ tboudreau 2005-03-02 09:38:44 UTC 
See attached screenshot

(hint:  I think we have code in here to set the height based on the 
font size;  we need to also check the icon size for the checkbox).
Comment 1 Jiri Rechtacek 2005-03-02 17:05:36 UTC 
Where is the screenshot? :-)
Tim, I'm not a fun of fixing this. No idea what to change. I saw
ServerPanel.adjustRowHeight() but I didn't know how to change the icon
size. Fuj :-(
Comment 2 _ tboudreau 2005-03-02 19:03:34 UTC 
Created attachment 20638 [details]
Screen shot
Comment 3 _ tboudreau 2005-03-02 19:07:17 UTC 
In our font size fixes a few years ago, there were a bunch of patches to make sure tables 
adjusted their cell height based on the font height.

Look for an overridden paint() method in the table displayed on this screen - it probably 
calls some method like 

private void adjustRowHeight(Graphics g) {
  FontMetrics fm = g.getFontMetrics(getFont());
  setRowHeight (fm.getHeight());
  }

If you want to cheat and do a quick fix:

setRowHeight ((Utilities.getOperatingSystem() | Utilities.OS_MAC) == 0 ? fm.getHeight() : 
fm.getHeight() + 4);

it will probably work forever.
Comment 4 Jiri Rechtacek 2005-03-03 16:00:08 UTC 
Nice! I see it's good enough, makes it nicer for all system. The cells
were cramped, a little space around did good the this table. Thanks
for hint.
Checking in src/org/netbeans/modules/autoupdate/ServerPanel.java;
/cvs/autoupdate/src/org/netbeans/modules/autoupdate/ServerPanel.java,v
 <--  ServerPanel.java
new revision: 1.15; previous revision: 1.14
done
Comment 5 Jaromir Uhrik 2005-03-14 12:57:52 UTC 
Verified in dev build #200403131900; Mac OS X.