This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 60187 - Javadoc association not functional if no sources
Summary: Javadoc association not functional if no sources
Status: VERIFIED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Krauskopf
URL:
Keywords: REGRESSION
Depends on:
Blocks:
 
Reported: 2005-06-17 12:29 UTC by Jesse Glick
Modified: 2005-11-25 10:03 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
patch1 (5.37 KB, text/plain)
2005-07-17 10:49 UTC, Martin Krauskopf 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2005-06-17 12:29:03 UTC 
Newly refactored JavadocForBinaryImpl is only associated with a project. But if
you have a binary platform with no source associations, there *is* no project
for a platform module, so Javadoc association does not work. Need to reintroduce
a global JFBQI, I guess. Was not caught by unit tests since it was not checking
this case.

(No such problem for SFBQI since when there is a source association, there is
also a project which can answer the query.)
Comment 1 Jesse Glick 2005-06-22 19:20:41 UTC 
SFBQ not working for me currently, either - have a dev build where default
platform is associated with the NB source tree, yet Go To Source does not work.
Needs to be investigated why.
Comment 2 Martin Krauskopf 2005-07-17 00:34:33 UTC 
Everything was caused by forgotten registered JFBQI in META-INF/services. I will
fixed it.
Comment 3 Martin Krauskopf 2005-07-17 00:36:40 UTC 
Fixed.

Checking in
src/META-INF/services/org.netbeans.spi.java.queries.JavadocForBinaryQueryImplementation;
new revision: 1.3; previous revision: 1.2
Checking in
src/org/netbeans/modules/apisupport/project/queries/JavadocForBinaryImpl.java;
new revision: 1.2; previous revision: 1.1
Comment 4 Martin Krauskopf 2005-07-17 01:39:52 UTC 
Ups. I misunderstood some concepts and having more NB instances running I
thought I got the solution. Now I see the problem and also that fix was ... ok,
a little nonsense :) - not fixed
Comment 5 Martin Krauskopf 2005-07-17 10:49:37 UTC 
Created attachment 23136 [details]
patch1
Comment 6 Martin Krauskopf 2005-07-17 10:50:03 UTC 
The path tries to find a module in an appropriate NetBeans platform and then
associate a javadoc for it. Probably needs to tune a little but seems to work
somehow.
Comment 7 Jesse Glick 2005-07-18 17:31:09 UTC 
The (new!) patch looks OK to me.
Comment 8 Martin Krauskopf 2005-07-18 19:19:34 UTC 
The old one wasn't good? :) Ok, I'll commit it.
Comment 9 Martin Krauskopf 2005-07-18 19:31:07 UTC 
Fixed.

Checking in
src/org/netbeans/modules/apisupport/project/queries/GlobalJavadocForBinaryImpl.java;
initial revision: 1.1
Checking in
src/org/netbeans/modules/apisupport/project/queries/JavadocForBinaryImpl.java;
new revision: 1.3; previous revision: 1.2
Checking in
src/META-INF/services/org.netbeans.spi.java.queries.JavadocForBinaryQueryImplementation;
new revision: 1.4; previous revision: 1.3
Comment 10 pzajac 2005-11-25 10:03:48 UTC 
verified