Created attachment 31496 [details]
screen shot

Can somebody please take a look at this Look&Feel problem ?

Assigning hopefully correct subcomponent.

This is as designed, although it may seem odd.

The reason is that we are painting these tabs ourselves, because of various
limitations of standard Swing JTabbedPane tabs. We concentrate on drawing
"native" LFs perfectly and we have one generic tab look for other LFs, so
JGoodies tabs will look a bit differently. 

This is a bug actually. Mr. Golovnin(@dev.java.net), may be the author of
JGoodies looks has give the detailed information about this bug. Would you
please fix it? JGoodies looks is really cool, it has menu shadow and many more
which is lack in Sun JDK/JRE, even in Mustang. The following is golovnin's
suggestion:

====
This is a bug (if any) in NetBeans Core (to be exactly in the method
org.netbeans.swing.plaf.util.UIUtil#isWindowsLF()). Please file a bug report
against NetBeans. As workaround you can force NetBeans to use a WindowsXP
customizations by defining the following system property: -Dnb.forceui=XP
Be aware, this property is not documented and may be changed or removed at any time!

This is a bug actually. Mr. Golovnin(@dev.java.net), may be the author of
JGoodies looks has give the detailed information about this bug. Would you
please fix it? JGoodies looks is really cool, it has menu shadow and many more
which is lack in Sun JDK/JRE, even in Mustang. The following is golovnin's
suggestion:

====
This is a bug (if any) in NetBeans Core (to be exactly in the method
org.netbeans.swing.plaf.util.UIUtil#isWindowsLF()). Please file a bug report
against NetBeans. As workaround you can force NetBeans to use a WindowsXP
customizations by defining the following system property: -Dnb.forceui=XP
Be aware, this property is not documented and may be changed or removed at any time!

We simply don't support JGoodies LF directly as we don't have resources to do
so, so we are using default painting of our tabs, which is similar to Win2000
LF, because Win2000 LF is simple and that way it won't clash with other LFs that
much.

Of course it would be nice if we were able to paint our tabs exactly in JGoodies
style when JGoodies LF is set, but we can't do this because of resources and
priorities. Sorry, but no way to have this fixed unless somebody from the
community writes support for JGoodies LF into our core/swing/tabcontrol module.

Hi, 
It's not so critical since Golovin's solution works, and I am happy with that.
But as Golovin's sugguestion, this issue is SUCH EASY can be fixed by just
cheating netbeans that JGoodies Windows is Windows by the following change in
org.netbeans.swing.plaf.util.UIUtil.java:

    public static boolean isWindowsLF () {
        if (Boolean.getBoolean("netbeans.winsys.forceclassic")) {
            return false;
        }
        String lfID = UIManager.getLookAndFeel().getID();

        // >>> Change the following line FROM
        return lfID.equals("Windows"); //NOI18N
        // TO
        return lfId.endsWith("Windows"); // NOI18N
    }

Because MOST components of JGoodies Windows is SAME as Windows (XP) look and
feel and it's unnecessary to write a set of tab controls.

Don't you think so?

Regards,
Wayne

Created attachment 32477 [details]
With flag nb.forceui=xp set, JGoodies Lnf works just fine!

OK, now I understand what is expected from me and I modified isWindowsLF method
as suggested. Reporter, please verify that the fix works, thanks.

Checking in UIUtils.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/util/UIUtils.java,v  <-- 
UIUtils.java
new revision: 1.8; previous revision: 1.7

Hi Dismonek,
It should change other 2 line to fix this issue:

IN:
org.netbeans.swing.plaf.Startup.findCustoms()

Line 348:
### CHANGED FROM
                default :
                        result = new WindowsLFCustoms();

### TO
                default :
                    // #79401 check if it's XP style LnF, for example jGoodies
WindowsLookAndFeel
                    if (UIUtils.isXPLF()) {
                        result = new XPLFCustoms();
                    } else {
                        result = new WindowsLFCustoms();
                    }

I have build and test, it works in JGoodies, Windows (XP and Classic), Metal,
Motif, but I didn't test GTK (on Li(U)nux).

Sorry about that.

Regards,
Wayne

Created attachment 32674 [details]
Fixed source code

integrated into main trunk, I hope this is last related change :-)

/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/Startup.java,v  <--  Startup.java
new revision: 1.17; previous revision: 1.16

closed