This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 81231 - bookmarks ModuleInstall has duplicated code
Summary: bookmarks ModuleInstall has duplicated code
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2006-07-27 09:40 UTC by Petr Nejedly
Modified: 2007-11-05 13:44 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2006-07-27 09:40:35 UTC 
It seems that the bookmarks module configures the settings twice, once directly
and second time through SettingsInitializer.
Generally, the ModuleInstall is quite compilcated :-(
Comment 1 Vitezslav Stejskal 2007-02-15 03:22:27 UTC 
Yes, it should be enough to add the settings from the initializer.
Comment 2 Vitezslav Stejskal 2007-03-22 10:25:34 UTC 
Removed the duplicate code and also some other Settings related mystery code in
the finish() method.

Checking in EditorBookmarksModule.java;
/cvs/editor/bookmarks/src/org/netbeans/modules/editor/bookmarks/EditorBookmarksModule.java,v
 <--  EditorBookmarksModule.java
new revision: 1.7; previous revision: 1.6
done