This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 85677 - Is not possible to start GlassFish
Summary: Is not possible to start GlassFish
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Vince Kraemer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-25 13:44 UTC by Petr Pisl
Modified: 2007-01-12 05:53 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
patch for flakey start/stop items... (4.37 KB, patch)
2006-09-26 07:51 UTC, Vince Kraemer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Pisl 2006-09-25 13:44:18 UTC
This is reproducible in release55_dev branch. I update the sources and start the
IDE with new userdir.
Add a GlassFish server. The Start action is disabled.

It is not reproducible with daily build from release55_dev, but from sources yes.
Comment 1 Sherold Dev 2006-09-25 13:57:39 UTC
I am also able to reproduce this issue.
Comment 2 judytang 2006-09-25 19:34:10 UTC
I am seeing this issue too in today's (9/25) releas55_dev build.  I can't
start or stop the server, the only thing I can do now is use CLI to start the
server and then do a refresh.  I can recreate this twice in my environment today.
Comment 3 Vince Kraemer 2006-09-26 02:06:39 UTC
restarting the iDE is a work-around
Comment 4 Vince Kraemer 2006-09-26 07:48:20 UTC
what i have found so far...

I started in StartSunServer, which is where supportsStartDeploymentManager is
implemented...

I found that the return value from this changed if the instance was "new" and
old/predefined...

I set some bp's in there and noticed that domain was equal to "", which could
never be true for the DM/instance that I was registering...

So I looked at the stack when domain was getting initialized and saw...

        at
org.netbeans.modules.j2ee.sun.ide.j2ee.StartSunServer.<init>(StartSunServer.java:125)
        at
org.netbeans.modules.j2ee.sun.ide.j2ee.StartSunServer.get(StartSunServer.java:160)
        at
org.netbeans.modules.j2ee.sun.ide.j2ee.OptionalFactory.getStartServer(OptionalFactory.java:67)
        at
org.netbeans.modules.j2ee.deployment.impl.ServerInstance.getStartServer(ServerInstance.java:444)
        at
org.netbeans.modules.j2ee.deployment.impl.ui.ServerRegistryNode$ServerChildren.createNodes(ServerRegistryNode.java:130)
        at org.openide.nodes.Children$Keys$KE.nodes(Children.java:2150)
        at org.openide.nodes.ChildrenArray.nodesFor(ChildrenArray.java:129)
        at org.openide.nodes.Children$Info.nodes(Children.java:1218)
        at org.openide.nodes.Children.updateAdd(Children.java:1009)
        at org.openide.nodes.Children.setEntries(Children.java:791)
        at org.openide.nodes.Children$Keys$2.run(Children.java:2036)
        at org.openide.util.Mutex.postRequest(Mutex.java:1119)
        at org.openide.util.Mutex.postWriteRequest(Mutex.java:489)
        at org.openide.nodes.Children$Keys.applyKeys(Children.java:2045)
        at org.openide.nodes.Children$Keys.setKeys(Children.java:2003)
        at
org.netbeans.modules.j2ee.deployment.impl.ui.ServerRegistryNode$ServerChildren.updateKeys(ServerRegistryNode.java:154)
        at
org.netbeans.modules.j2ee.deployment.impl.ui.ServerRegistryNode.updateKeys(ServerRegistryNode.java:92)
        at
org.netbeans.modules.j2ee.deployment.impl.ui.ServerRegistryNode.instanceAdded(ServerRegistryNode.java:83)
        at
org.netbeans.modules.j2ee.deployment.impl.ServerRegistry.fireInstanceListeners(ServerRegistry.java:426)
        at
org.netbeans.modules.j2ee.deployment.impl.ServerRegistry.addInstanceImpl(ServerRegistry.java:345)
        at
org.netbeans.modules.j2ee.deployment.impl.ServerRegistry.addInstance(ServerRegistry.java:279)
        at
org.netbeans.modules.j2ee.deployment.plugins.api.InstanceProperties.createInstanceProperties(InstanceProperties.java:140)
        at
org.netbeans.modules.j2ee.sun.api.SunURIManager.createInstanceProperties(SunURIManager.java:64)
        at
org.netbeans.modules.j2ee.sun.ide.j2ee.ui.AddDomainWizardIterator.createIP(AddDomainWizardIterator.java:327)
 .
 .
 .

The StartSunServer object accesses an InstanceProperties object that is
uninitialized...

This bug has been in the product for awhile, masked by the fact that there were
multiple DM objects and multiple StartSunServer objects...

The attached diff seems to resolve the issue.
Comment 5 Vince Kraemer 2006-09-26 07:51:57 UTC
Created attachment 34487 [details]
patch for flakey start/stop items...
Comment 6 Vince Kraemer 2006-09-26 16:25:37 UTC
filer applied the patch and reported that they were unable to reproduce the bug.
Comment 7 _ ludo 2006-09-26 23:32:44 UTC
ok for dev so that other can test. Looks good so far.
Comment 8 Vince Kraemer 2006-09-27 00:23:56 UTC
http://serverplugins.netbeans.org/source/browse/serverplugins/sun/appsrv81/src/org/netbeans/modules/j2ee/sun/ide/j2ee/StartSunServer.java?r1=1.4.4.6.2.19.2.1&r2=1.4.4.6.2.19.2.2

this fix MUST be checked in to release55 IF the diffs for 77122 (or some
variant) gets applied to release55