This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 87079 - xml/retriever has too many friends
Summary: xml/retriever has too many friends
Status: RESOLVED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Samaresh Panda
URL:
Keywords: API
Depends on:
Blocks:
 
Reported: 2006-10-13 11:16 UTC by Andrei Badea
Modified: 2007-07-23 17:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2006-10-13 11:16:27 UTC 
The xml/retriever module has 21 friends, which is higher than the maximum number
of friends (14). It should probably provide a public API instead of a friend one.
Comment 1 Samaresh Panda 2007-03-28 01:04:53 UTC 
The fix has long been integrated. xml/retriever does declare public packages.

<public-packages>
   <package>org.netbeans.modules.xml.retriever</package>
   <package>org.netbeans.modules.xml.retriever.catalog</package>
</public-packages>
Comment 2 tonybeckham 2007-04-11 22:48:55 UTC 
abadea:
This issue submitted by you is marked as resolved. Since it relates to some
source code specifics, QA is unable to verify it. Could you please verify this
issue and mark it as verified or reopen it?
Comment 3 Andrei Badea 2007-04-12 14:07:32 UTC 
Reopening then. By "it should probably provide a public API instead of a friend
one" in desc1 I meant "you should turn this into a public API and have an API
review for it". Not just "change friend-packages to public-packages". 

Has an API review been done for xml/retriever?
Comment 4 Samaresh Panda 2007-05-11 22:39:39 UTC 
This module was introduced by the EntPack during 5.5 development time frame.
Soon this module became very useful and a lot of modules were added to the
friends list. Apparently at some point, there were 21 modules in the list.

Then came 6.0 development and 6.0 didn't allow more than 14 in the friends list.
Time wise it was important to migrate to 6.0. So there was no choice but to make
the APIs public.
Comment 5 Andrei Badea 2007-05-14 11:48:25 UTC 
Sure. Such a high number of clients shows clearly that the API should be public.
However, you also need to declare a degree of stability, so that clients of the
API can know if they can expect to be broken by future changes to the API. You
should also have an API review, so that others can look at the API and tell you
whether the API design allows for this degree of stability.

Consider reading 

http://openide.netbeans.org/tutorial/reviews/

and especially

http://openide.netbeans.org/tutorial/api.html#review
Comment 6 Samaresh Panda 2007-06-22 01:38:48 UTC 
I've requested for a review. See issue 107752.
Comment 7 Samaresh Panda 2007-07-23 17:23:03 UTC 
abadea,
This module no longer have a lot of friends. I'm marking this fixed as I have requested for a review. Feel free to
comment on 107752.