This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 88069 - Don't use UI thread when adding new files to project
Summary: Don't use UI thread when adding new files to project
Status: RESOLVED DUPLICATE of bug 76817
Alias: None
Product: cnd
Classification: Unclassified
Component: Project (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Thomas Preisler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-26 10:14 UTC by Vladimir Kvashin
Modified: 2007-09-06 18:03 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kvashin 2006-10-26 10:14:47 UTC 
Now adding new items for project is done in the UI thread. This isn't critical
if user adds one or several files. But if "add existing items from directory" is
invoked for large projects (like MySQL, which has more than 2000 files), UI
hangs for minutes. This is unacceptable.
Comment 1 Vladimir Voskresensky 2006-10-26 10:58:00 UTC 
I think, it's P2, because significantly affect responsiveness and performance.
And at the same time no any notification to user about long-time taks.

Impl. comment:
don't use Vector for big collections.
Synchronized ArrayList is 2 times faster than Vector.
Comment 2 Thomas Preisler 2006-10-26 16:20:56 UTC 
See also http://cnd.netbeans.org/issues/show_bug.cgi?id=76817
Comment 3 Vladimir Voskresensky 2006-10-26 18:32:29 UTC 
seems, we can improve speed up by changing listener.
now we have: 
for each new added file {
 inform all listeners that new file was added
}
=> for listeners it´s impossible to estimate how many other calls it will have.

we can do:
create list of all new files
for each listener {
  inform listener about added list of files
}

In this case we (code model part) could provide progress to indicate that some
number of files is under parse.

Although one problem still remains.
¨create list of all new files¨ is expensive => project system should enforce
progress bar in infinite state as well for indicating some activity.
And of course this phase should be moved out from UI thread.
Comment 4 Vladimir Kvashin 2006-10-26 22:46:26 UTC 
Yes, creating a queue of files being added and putting it into parser queue in a
separate thread will improve sutuation a bit.

But even when code model switched off at all, UI hangs for more than a minute
when user adds 2000 files to a project.
Comment 5 Thomas Preisler 2006-10-30 02:06:53 UTC 
Now files are added to the project from a seperate thread. This fixes the major
problem in this issue.

There are other good suggestions in this bug report of how to improve
performance. I will close this issue as dup of 76817 now the main issue has been
fixed and deal with all performance issues at once. I don't believe these are so
bad that they are p1 or p2.

*** This issue has been marked as a duplicate of 76817 ***