This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 96419 - NbPresenter should not override borders if the LAF has already supplied them
Summary: NbPresenter should not override borders if the LAF has already supplied them
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Dialogs&Wizards (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: David Strupl
URL:
Keywords:
Depends on:
Blocks: 32488
  Show dependency tree
 
Reported: 2007-02-23 10:48 UTC by David Strupl
Modified: 2008-12-22 12:00 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
proposed patch (4.49 KB, patch)
2007-02-23 15:34 UTC, David Strupl 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Strupl 2007-02-23 10:48:28 UTC 
I will create a patch that will turn off specifying borders on some panels if
the Look And Feel has already set its own borders. This issue is a follow up to
32254 - the original patch from the old issue no longer applies to the trunk. I
will create a new one and put it here.
Comment 1 David Strupl 2007-02-23 15:34:07 UTC 
Created attachment 38872 [details]
proposed patch
Comment 2 David Strupl 2007-02-23 15:36:09 UTC 
Can you please review the patch? Please note that I don't have Mac or some
exotic LAF, I can verify it only on my config (Linux, Ubuntu (Gnome), JDK 1.5,
Default LAF). Is someone able to verify on other JDKs/LAFs?
Comment 3 _ rkubacki 2007-02-26 09:34:46 UTC 
It would be good to test GTK L&F too. If you could run 6.0u1 build (it should be
out at the end of this week, some builds are available at jdk6.dev.java.net) it
would be good check. Dafe  knows better about various things that work
differently with this L&F.
Comment 4 David Strupl 2007-03-02 08:55:22 UTC 
Dafe, can you please check the patch? Anybody able to test on the platforms that
you should support?
Comment 5 David Strupl 2007-03-06 08:15:55 UTC 
Can I apply the patch? If there will be no objections I will apply the patch
soon ;-) I am ready to fix any bugs resulting from this patch. Of course I hope
there will not be any but just in case.
Comment 6 David Strupl 2007-03-07 11:42:28 UTC 
Fixed. I have applied the fix. Sorry I have lost the revisions of the files due
to issuezilla down state. But I have applied the fix exactly according to the
attachment. As I said if there are any complaints please assigne them to me. Thanks.
Comment 7 David Simonek 2007-03-07 11:56:37 UTC 
Sorry for jumping so late. I'll test on GTK, but I'm not sure what to test,
which dialogs specifically? Is there any dialog where the error was easily
visible and how? Thanks.
Comment 8 David Strupl 2007-03-07 12:05:25 UTC 
Hello,

there should be no change compared to the previous state. The idea of the patch
is that on the default LAFs it should run exactly the same code as before. Only
on some exotic LAFs (e.g. our private closed source Nokia Look and Feel) the IDE
code should not override borders if the LAF had already supplied them.

The dialogs are all dialogs using NotifyDescriptor, DialogDescriptor or
WizardDescriptor - simply all dialogs in NB sources. File --> New wizard was
main test case.

You can check whether e.g. around the "Ok" "Cancel" buttons there is enough
space from the edge of the dialog.

The check is simply to look at the modal dialogs and see whether the empty
border is present where it should be.

Thanks for looking into it. BTW the change is in the current trunk - shold be
enough to just cvs update & build & test the current trunk build.
Comment 9 David Simonek 2007-03-07 12:21:56 UTC 
That's what i'm doing right now :-) And it looks OK on GTK, patch is fine.