This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 16017 - I18N - Search Results window saved with localized settings name
Summary: I18N - Search Results window saved with localized settings name
Status: CLOSED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 3.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: David Simonek
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2001-09-28 10:55 UTC by Jesse Glick
Modified: 2008-12-23 09:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2001-09-28 10:55:56 UTC 
[dev sep 26] After using the Search tool, I see in my user dir a file:
system/Windows/WindowManager/Editing/Search Results.wsmode
The filename here is I believe a localized string, which is not good
(imagine it being in Japanese on an operating system which does not
support non-ASCII characters in filenames). There seems to be some
system in the winsys for making a "safe" filename for top components
(system/Windows/Components/*.settings); cannot this also be used for
modes (*.wsmode and sister directories)?
Comment 1 David Simonek 2001-11-01 09:33:36 UTC 
Safe filenames are now used for modes and workspaces. However, if
search results wants to have unlocalized mode name, they have to
provide one, either in xml layer or in direct mode creation through
open API.
Comment 2 Jesse Glick 2002-11-27 17:04:11 UTC 
Fixed long ago.
Comment 3 Jesse Glick 2002-11-27 17:12:01 UTC 
Specifically: the string "Search Results" is *both* the hardcoded code
name for the mode (ugly but true) and the English localization of
that. See

ResultViewTopComponent.MODE_NAME

its constructor:

setName(NbBundle.getBundle(ResultViewTopComponent.class).getString("TEXT_TITLE_SEARCH_RESULTS"));
// NOI18N

and also SearchPerformer:

                m = w.createMode(ResultViewTopComponent.MODE_NAME,
                                 resultWindow.getName(), null);
Comment 4 Quality Engineering 2003-07-01 16:38:08 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.