This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 181808 - I18N : hardcoded strings in SpellcheckerOptionsPanel.java
Summary: I18N : hardcoded strings in SpellcheckerOptionsPanel.java
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Spellchecker (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Jan Lahoda
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2010-03-10 21:02 UTC by Masaki Katakai
Modified: 2010-03-14 20:09 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2010-03-10 21:02:41 UTC 
I understand it's not time to finalize UI strings now but please consider
to extract these strings to Bundle.properties by default.

It seems that these strings are hardcoded now, but will be localized at FCS.

org/netbeans/modules/spellchecker/options/SpellcheckerOptionsPanel.java:

                        setError("Locale is empty");
                        setError("Invalid locale");
                        setError("Unknown language");
                            setError("Unknown country");
                            setError("Unsupported locale");

        jPanel2.setBorder(javax.swing.BorderFactory.createTitledBorder("Dictionaries"));
        org.openide.awt.Mnemonics.setLocalizedText(jButton4, "Add...");
        org.openide.awt.Mnemonics.setLocalizedText(jButton5, "Remove");
        DialogDescriptor dd = new DialogDescriptor(panel, "Add Dictionary");
Comment 1 Masaki Katakai 2010-03-10 21:06:43 UTC 
These "Spellchecker" needs to be extracted to Bundle.properties too. I think it will be displayed on Tab.

org/netbeans/modules/spellchecker/options/SpellcheckerOption.java:

    @Override
    public String getDisplayName() {
        return "Spellchecker";
    }

    @Override
    public String getTooltip() {
        return "Spellchecker";
    }
Comment 2 Jan Lahoda 2010-03-14 20:09:50 UTC 
The panels use bundles now:
http://hg.netbeans.org/jet-main/rev/e82e46573210
The SpellcheckerOption file does not exist anymore (the new registration loads the name from a bundle).