This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 224877 - Patch for: "Generate JAX-WS-client" dialog: "set proxy" button is always enabled but shouldn't
Summary: Patch for: "Generate JAX-WS-client" dialog: "set proxy" button is always enab...
Status: RESOLVED FIXED
Alias: None
Product: webservices
Classification: Unclassified
Component: Code (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Milan Kuchtiak
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-01-14 21:08 UTC by markiewb
Modified: 2013-07-25 02:27 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Shows the dialog with the issue (58.42 KB, image/png)
2013-01-14 21:09 UTC, markiewb
Details
Proposed patch (1.52 KB, patch)
2013-06-19 15:43 UTC, markiewb
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2013-01-14 21:08:51 UTC
[ BUILD # : 201301102100 ]
[ JDK VERSION : 1.7.0_09 ]

ACTUAL: "set proxy" button is always enabled - See screenshot
EXPECTED: "set proxy" button should be only enabled when radio button 
"WSDL URL" is checked

----

Product Version: NetBeans IDE 7.3 RC1 (Build 201301102100)
Java: 1.7.0_10; Java HotSpot(TM) 64-Bit Server VM 23.6-b04
Runtime: Java(TM) SE Runtime Environment 1.7.0_10-b18
System: Windows 7 version 6.1 running on amd64; Cp1252; de_DE (nb)
Comment 1 markiewb 2013-01-14 21:09:35 UTC
Created attachment 130214 [details]
Shows the dialog with the issue
Comment 2 markiewb 2013-06-19 15:43:41 UTC
Created attachment 136043 [details]
Proposed patch

I like to propose a patch to solve this issue. The patch 
* enables/disables the proxy button regarding to the checked state of its radio button

@NB-Dev: Please review and commit if appropriate.
Comment 3 Jiri Kovalsky 2013-07-23 10:14:45 UTC
Reassigning from Denis to Milan.
Comment 4 Milan Kuchtiak 2013-07-23 11:57:09 UTC
Thank You for the patch.

However, the <<Set Proxy>> button is not entirely related to the WSDL URL radio button, as though it looks like it was.

Imagine the case when local wsdl file (see Local File option) references some remote XML schema. In that case, and in case proxy is needed for wsimport, the wizard wouldn't generate artifacts successfully.

Note that for ant projects, normally wsimport task runs in the same JVM as Netbeans, so the <<Set Proxy>> button has some sense here.  

On the other hand, the "Web Service from WSDL" wizard, which is very similar to WS Client wizard , doesn't contain <<Set Proxy>> at all, which is some inconsistency.

So may by we could either remove the <<Set Proxy>> button from WS Client Wizard completely, or add <<Set Proxy>> to "Web Service from WSDL" wizard as well.
Comment 5 markiewb 2013-07-23 21:44:15 UTC
(In reply to comment #4)
> So may by we could either remove the <<Set Proxy>> button from WS Client Wizard
> completely, or add <<Set Proxy>> to "Web Service from WSDL" wizard as well.

It is up to you. Its your code. *g*
Comment 6 Milan Kuchtiak 2013-07-24 10:21:06 UTC
Fixed.

Finally agreed to remove the button.

The Set Proxy button was removed from :
- New Web Service Client wizard
- Services tab -> Web Services -> Add Web Service dialog

Also asked documentation people to update the help sets to both changes.

See:
http://hg.netbeans.org/web-main/rev/01afc8c31d81
http://hg.netbeans.org/web-main/rev/06d1638a3b2e
Comment 7 Quality Engineering 2013-07-25 02:27:22 UTC
Integrated into 'main-silver', will be available in build *201307242300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/01afc8c31d81
User: Milan Kuchtiak <mkuchtiak@netbeans.org>
Log: #224877: Set Proxy buton removed from the wizard