This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I cloned a Git repository using HTTPS and agreed to save my password. But when I look for it in seahorse, it is difficult to find: there is a long list of keys named guri_password12:34:de:ad:be:ef:… or whatever, with no clear way to tell what site they are from. Nicest would be to use the original key with unsafe characters escaped or translated to '_', so that the site appears in the seahorse key list, but if you are going to use a hash then please at least show this information in the description: diff --git a/versioning.util/src/org/netbeans/modules/versioning/util/KeyringSupport.java b/versioning.util/src/org/netbeans/modules/versioning/util/KeyringSupport.java --- a/versioning.util/src/org/netbeans/modules/versioning/util/KeyringSupport.java +++ b/versioning.util/src/org/netbeans/modules/versioning/util/KeyringSupport.java @@ -71,6 +71,9 @@ } Keyring.delete(getKeyringKey(keyPrefix, key)); } else { + if (description == null) { + description = key; + } if (LOG.isLoggable(Level.FINE)) { LOG.log(Level.FINE, "Saving password for {0}:{1}", new String[] {keyPrefix, key}); //NOI18N if (PRINT_PASSWORDS) {
Created attachment 131068 [details] Same patch, w/ MQ headers
> Nicest would be to use the original key with unsafe characters escaped or > translated to '_', so that the site appears in the seahorse key list I am not sure what the unsafe characters are/could be in case of different keyring storage implementations (on Mac, KDE, Gnome etc.). So the safest way seemed to use a hash as a key. Do you have any idea what characters can and what cannot be used in a key?
KeyringProviderTestBase checks usage of exotic Unicode characters in keys, passwords, and descriptions, across providers. FWIW HudsonManagerImpl.simplifyServerLocation does a simple substitution for readability but does not try to escape arbitrary characters; at least in this case you are only starting with characters permitted in URLs anyway.
i applied your patch: core-main #52791f2d7d25. I'll take a look and try to fix it properly later
Integrated into 'main-golden', will be available in build *201302270948* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/52791f2d7d25 User: Jesse Glick <jglick@netbeans.org> Log: #225809: show description for SCM keyring entries.
fix: http://hg.netbeans.org/core-main/rev/53c16107b691
Integrated into 'main-golden', will be available in build *201305292301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/53c16107b691 User: Ondrej Vrabec <ovrabec@netbeans.org> Log: #225809 - Git HTTPS passwords stored with no meaningful key or description