This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 249214 - org.netbeans.modules.db.explorer.DatabaseConnection.isVitalConnection: LowPerformance took 43197 ms.
Summary: org.netbeans.modules.db.explorer.DatabaseConnection.isVitalConnection: LowPer...
Status: RESOLVED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 8.0
Hardware: All All
: P3 normal (vote)
Assignee: matthias42
URL:
Keywords: PATCH_AVAILABLE, PERFORMANCE
: 246591 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-12-09 00:22 UTC by brettryan
Modified: 2015-02-02 02:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 213995

Attachments
nps snapshot (39.16 KB, application/nps)
2014-12-09 00:22 UTC, brettryan 		Details
potential patch v1 (1.43 KB, patch)
2014-12-12 18:06 UTC, matthias42 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description brettryan 2014-12-09 00:22:40 UTC 
This bug was originally marked as duplicate of bug 221602, that is already resolved. This bug is still valid, so this seems to be another bug, but it might be related.

Build: NetBeans IDE 8.0.1 (Build 201408251540)
VM: Java HotSpot(TM) 64-Bit Server VM, 25.20-b23, Java(TM) SE Runtime Environment, 1.8.0_20-b26
OS: Mac OS X

User Comments:
brettryan: Executing SQL query.



Maximum slowness yet reported was 43197 ms, average is 43197
Comment 1 brettryan 2014-12-09 00:22:41 UTC 
Created attachment 150972 [details]
nps snapshot
Comment 2 matthias42 2014-12-12 18:06:08 UTC 
Created attachment 151084 [details]
potential patch v1

It looks like the driver makes expensive calls while getWarnings is run.

The attached patch moves the warning retrieval into the time limited call in checkClosedWithTimeout.
Comment 3 matthias42 2015-01-22 10:34:18 UTC 
Patch commited as: http://hg.netbeans.org/core-main/rev/445492ab23fb
Comment 4 Quality Engineering 2015-01-23 04:06:45 UTC 
Integrated into 'main-silver', will be available in build *201501230002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/445492ab23fb
User: Matthias Blaesing <matthias42@netbeans.org>
Log: #249214: connection.getWarnings is potentially slow, move getWarnings call into time limited Callable
Comment 5 matthias42 2015-01-25 19:40:12 UTC 
Please help with QA - in the nightly build the fix can be tested. Please check if your problem is fixed there. If so, please change the status of this bug to "VERIFIED".
Comment 6 brettryan 2015-01-25 23:53:24 UTC 
Will do, I need to wait a few days when I go into the office as from home I only have a dialup connection.
Comment 7 matthias42 2015-01-31 13:15:35 UTC 
*** Bug 246591 has been marked as a duplicate of this bug. ***
Comment 8 Quality Engineering 2015-02-02 02:44:36 UTC 
Integrated into 'main-silver', will be available in build *201502020002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/f23f043b4a4d
User: Matthias Blaesing <matthias42@netbeans.org>
Log: #246591:Integrate missing cleanups from #249214 - remove unecessary logging and move to java7 features