This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220317 - Patch for: Test result window: No icons for stacktrace nodes but space used
Summary: Patch for: Test result window: No icons for stacktrace nodes but space used
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: JUnit (show other bugs)
Version: 7.3
Hardware: PC Windows 7
: P4 normal (vote)
Assignee: Theofanis Oikonomou
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2012-10-17 17:30 UTC by markiewb
Modified: 2012-11-21 13:47 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Shows the wasted space (22.82 KB, image/png)
2012-10-17 17:30 UTC, markiewb 		Details
Proposed patch (2.06 KB, patch)
2012-11-18 15:20 UTC, markiewb 		Details | Diff
Patch in action (27.25 KB, image/png)
2012-11-18 15:21 UTC, markiewb 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description markiewb 2012-10-17 17:30:20 UTC 
[ BUILD # : 201210070002 ]
[ JDK VERSION : 1.6.35 ]

In the testresult window there are no icons for stacktrace nodes. That is OK.

But remove the empty icon. It is only a waste of horizontal space now.

See screenshot.
Comment 1 markiewb 2012-10-17 17:30:49 UTC 
Created attachment 126105 [details]
Shows the wasted space
Comment 2 Theofanis Oikonomou 2012-11-16 22:34:47 UTC 
I think that the space is correct in order to visually indicate that the stacktrace belongs to the specific test case.
Comment 3 markiewb 2012-11-18 15:09:02 UTC 
(In reply to comment #2)
> I think that the space is correct in order to visually indicate that the
> stacktrace belongs to the specific test case.

No i do not think so, because the issue is the following: There are nodes without icons, but the space for the "non-existing" icon is still used.

So i reopened the issue.
Comment 4 markiewb 2012-11-18 15:20:43 UTC 
Created attachment 127998 [details]
Proposed patch

I like to propose the following patch. 
Details: For callstackFrameNodes (with no icons) they will be painted using the NoIconTreeCellRenderer without the space for an icon.

@NetBeans-Dev: Please review, discuss and commit. Thank you.
Comment 5 markiewb 2012-11-18 15:21:09 UTC 
Created attachment 127999 [details]
Patch in action
Comment 6 Theofanis Oikonomou 2012-11-19 10:51:49 UTC 
Thanks for the patch. Fixed: http://hg.netbeans.org/core-main/rev/c4beb7f52f8f
Comment 7 Quality Engineering 2012-11-21 13:47:56 UTC 
Integrated into 'main-golden', will be available in build *201211211016* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/c4beb7f52f8f
User: Theofanis Oikonomou <theofanis@netbeans.org>
Log: Issue #220317 - Patch for: Test result window: No icons for stacktrace nodes but space used