This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
I would like to expose class XMLDefaultTokenContext from module xml/text-edit as friend API for module web/jspsyntax. At the same time, it would be moved to package org.netbeans.modules.xml.text.api. This would eliminate the implementation dependency between these two modules, see also issue 54465. The proposal is not to design new API, just to formalize the current contract that already exists in the form of implementation dependency.
Created attachment 27017 [details] The new API class
Requesting a fast track review.
XMLTokenIDs will get exposed as well, right?
No, I was not planning to expose it, as it is not needed outside this module. Should I?
Depends on whether you need to depend on the token ids defined in the XMLTokenIDs. I thought that you want to but if not then you do not need to publish XMLTokenIDs.
Done. Checking in nbproject/project.xml; /cvs/xml/text-edit/nbproject/project.xml,v <-- project.xml new revision: 1.6; previous revision: 1.5 done RCS file: /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/api/XMLDefaultTokenContext.java,v done Checking in src/org/netbeans/modules/xml/text/api/XMLDefaultTokenContext.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/api/XMLDefaultTokenContext.java,v <-- XMLDefaultTokenContext.java initial revision: 1.1 done Checking in src/org/netbeans/modules/xml/text/completion/SyntaxQueryHelper.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/completion/SyntaxQueryHelper.java,v <-- SyntaxQueryHelper.java new revision: 1.14; previous revision: 1.13 done Checking in src/org/netbeans/modules/xml/text/indent/XMLFormatter.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/indent/XMLFormatter.java,v <-- XMLFormatter.java new revision: 1.22; previous revision: 1.21 done Checking in src/org/netbeans/modules/xml/text/syntax/XMLDefaultSyntax.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLDefaultSyntax.java,v <-- XMLDefaultSyntax.java new revision: 1.13; previous revision: 1.12 done Removing src/org/netbeans/modules/xml/text/syntax/XMLDefaultTokenContext.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLDefaultTokenContext.java,v <-- XMLDefaultTokenContext.java new revision: delete; previous revision: 1.6 done Checking in src/org/netbeans/modules/xml/text/syntax/XMLOptions.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLOptions.java,v <-- XMLOptions.java new revision: 1.12; previous revision: 1.11 done Checking in src/org/netbeans/modules/xml/text/syntax/XMLSettingsInitializer.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLSettingsInitializer.java,v <-- XMLSettingsInitializer.java new revision: 1.21; previous revision: 1.20 done Checking in src/org/netbeans/modules/xml/text/syntax/XMLSyntaxSupport.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLSyntaxSupport.java,v <-- XMLSyntaxSupport.java new revision: 1.27; previous revision: 1.26 done Checking in src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/XMLTokenIDs.java,v <-- XMLTokenIDs.java new revision: 1.3; previous revision: 1.2 done Checking in src/org/netbeans/modules/xml/text/syntax/dom/ProcessingInstructionImpl.java; /cvs/xml/text-edit/src/org/netbeans/modules/xml/text/syntax/dom/ProcessingInstructionImpl.java,v <-- ProcessingInstructionImpl.java new revision: 1.6; previous revision: 1.5 done Checking in nbproject/project.xml; /cvs/web/jspsyntax/nbproject/project.xml,v <-- project.xml new revision: 1.14; previous revision: 1.13 done Checking in src/org/netbeans/modules/web/core/xmlsyntax/JspXMLTokenContext.java; /cvs/web/jspsyntax/src/org/netbeans/modules/web/core/xmlsyntax/JspXMLTokenContext.java,v <-- JspXMLTokenContext.java new revision: 1.2; previous revision: 1.1 done Checking in cluster-impl-deps.txt; /cvs/ide/golden/cluster-impl-deps.txt,v <-- cluster-impl-deps.txt new revision: 1.8; previous revision: 1.7 done Checking in friend-packages.txt; /cvs/ide/golden/friend-packages.txt,v <-- friend-packages.txt new revision: 1.10; previous revision: 1.9 done Checking in impl-deps.txt; /cvs/ide/golden/impl-deps.txt,v <-- impl-deps.txt new revision: 1.43; previous revision: 1.42 done