This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 108229 - serverplugin code changes to support...
Summary: serverplugin code changes to support...
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Peter Liu
URL:
Keywords:
Depends on:
Blocks: 106890
  Show dependency tree
 
Reported: 2007-06-26 23:16 UTC by Vince Kraemer
Modified: 2007-07-10 01:21 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
cvs diff for ContainerChildFactory.java (1.84 KB, text/plain)
2007-07-05 23:57 UTC, Peter Liu
Details
modified ContainerChildFactory.java (15.99 KB, text/plain)
2007-07-05 23:59 UTC, Peter Liu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vince Kraemer 2007-06-26 23:16:01 UTC
issue 106890.

this task is just a placeholder to anchor discussion and reviews, etc.
Comment 1 Peter Liu 2007-06-30 06:38:36 UTC
Vince,

I've been looking at the following files you pointed me to:

serverplugins/sun/appsrvbride/src/org.netbeans.modules.j2ee.sun.util.ContainerChildFactory
serverplugins/sun/appsrvbride/src/org.netbeans.modules.j2ee.sun.bridge.apis.NodeExtension

I noticed that the ContainerChildFactory currently only allows one extension node to be added.  I had to make some
changes in order to install more than one extension node. I'll post the diff later for review.

Furthermore, I have some issue with regard to the NodeExtension api. Currently, there is no way for me to identify which
server instance my access manager node is attaching to. More specifically, I need the server instance URL so I can
derive the installation root for the appserver.  The reason is I need the installation root in order to look up the AM
jar files.  I couldn't find any way for me this from the appsrvbridge api.  Is it possible to enhance the appsrvbrige
api to return the correspond server instance URL?

Comment 2 Peter Liu 2007-07-05 18:54:47 UTC
Any response to my previous comment? 
Comment 3 Vince Kraemer 2007-07-05 22:20:46 UTC
Diffs: great. I will be happy to look at them.

getting the "Platform Location" of a registered domain "inside" the NodeExtension....

You should be able to do the following in your NodeExtension implementation...

public Node getAppserverExtensionNode(AppserverMgmtController controller) {
  ...
  File rootDir = ((SunDeploymentManagerInterface) controller.getDeploymentManager()).getPlatformRoot();
  ...
}

We can tighten this up a bit more... but it will get you started...
Comment 4 Peter Liu 2007-07-05 23:57:38 UTC
Created attachment 44760 [details]
cvs diff for ContainerChildFactory.java
Comment 5 Peter Liu 2007-07-05 23:58:27 UTC
In order to get the code for getting the platform working, I had to add my identity module as a friend to the common api
project.  I also had to include the jsr88javax.jar on my cp.extra property to work around a compilation error
complaining about no access to the DeploymentManager class in the javax.enterprise.. package.  Other than, the code
works for me.

BTW, I am attaching the diffs and the modified ContainerChildFactory.java. For some reason, I couldn't generate a patch.

Comment 6 Peter Liu 2007-07-05 23:59:29 UTC
Created attachment 44761 [details]
modified ContainerChildFactory.java
Comment 7 Vince Kraemer 2007-07-06 15:43:36 UTC
New friendship: ok

Adding the jar to cp.extra: That may not be okay with folks... I am not sure who to ask about his, though.

The diffs: Look good. Thanks.  Feel free to check them in when you commit your extension node...

Comment 8 Peter Liu 2007-07-06 19:31:03 UTC
Is there a reason why there is no corresponding NB library module for the jsr88 api? Anyway, since I already have to add
the appservbridge.jar to my cp.extra, I guess one extra jar file is not going to be a big deal, I hope.  For now, I'll
just do it this way. If people complain, we can then spend the resource to fix it.

I'll check in the changes.  Thanks for all your help.

Comment 9 Peter Liu 2007-07-06 19:43:29 UTC
Here is the CVS log for the checkin.

IDE:-------------------------------------------------
IDE: [7/6/07 11:39 AM] Committing "ContainerChildFactory.java" started
Checking in ContainerChildFactory.java;
/cvs/serverplugins/sun/appsrvbridge/src/org/netbeans/modules/j2ee/sun/util/ContainerChildFactory.java,v  <-- 
ContainerChildFactory.java
new revision: 1.5; previous revision: 1.4
done
IDE: [7/6/07 11:39 AM] Committing "ContainerChildFactory.java" finished
Comment 10 Peter Liu 2007-07-06 19:53:01 UTC
Added org.netbeans.modules.identity.server.manager as a friend package to the common api project.


IDE:-------------------------------------------------
IDE: [7/6/07 11:49 AM] Committing "project.xml" started
Checking in project.xml;
/cvs/serverplugins/sun/appsrv/nbproject/project.xml,v  <--  project.xml
new revision: 1.18; previous revision: 1.17
done
IDE: [7/6/07 11:49 AM] Committing "project.xml" finished
IDE: [7/6/07 11:49 AM] Diffing "project.xml" finished

Comment 11 Peter Liu 2007-07-10 01:21:59 UTC
All the necessary changes have been checked into NB6 trunk.