This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 142146 - [65cat] Clean up the formatting settings customizers
Summary: [65cat] Clean up the formatting settings customizers
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Settings (show other bugs)
Version: 6.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
: 141974 141983 144044 (view as bug list)
Depends on:
Blocks: 141111 141296 142148 142636 144067 248397
  Show dependency tree
 
Reported: 2008-07-29 21:42 UTC by Michel Graciano
Modified: 2014-11-07 08:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michel Graciano 2008-07-29 21:42:53 UTC
[ BUILD # : 200807291401 ]
[ JDK VERSION : 1.6.0_07 ]

The reason is, IMO if it is 'All Languages' settings, why when I
change 'Expand Tabs to Spaces' for it, the Java is not updated? It
makes sense because 'All Languages' is the settings for languages
except Java (and other that will appear).
Comment 1 Jiri Prox 2008-07-30 07:53:52 UTC
Actually this should work also for java, but there is bug now

*** This issue has been marked as a duplicate of 141974 ***
Comment 2 Jiri Prox 2008-07-30 07:56:33 UTC
Sorry, my fault, you're right
Comment 3 Michel Graciano 2008-07-30 13:38:57 UTC
I commented issue 141974 about this ambiguous meaning.
Comment 4 Vitezslav Stejskal 2008-08-01 12:55:27 UTC
I'm sorry for the confusion, but the intended use is as follows:

- 'All languages' really _does_ control settings of all languages (eg including java)
- #141974 is a valid problem and should be fixed

In fact, the UI controls used for 'All languages' should be used by Java and all the other languages that provide their
own customizers. This is still work in progress.

So, unless I missed something in the issues I think this one should be closed as INVALID and #141974 should be reopened.
Comment 5 Petr Dvorak 2008-08-01 16:48:28 UTC
I am very, very confused, Vita... If the resolution of the two issues was opposite, I would have no problem, but I don't
get what you said...

So, what you are basically saying is that if I check the checkbox "Expand Tabs to spaces" (ETTS) for the "All
Languages", checkbox for Java (and all other languages in the combo) gets checked (because if it was not checked it
would not make any sense - how would you disable ETTS only for Java then, leaving the option enabled for "All Languages"
except Java?).

And if you then uncheck the checkbox for Java, ETTS should be disabled for Java and remained enabled for all other
languages?

But what is the status of the checkbox in "All Languages" then? I think this makes it confusing...

Setting should be customizable for all installed languages (Java, Ruby, ...) and there should be the settings for
remaining files (All Other Languages - for example sh, bat, ...).

IMO if you want to make settings for "All Languages", they have to be set in "atomic action", for example by pressing a
button ("Set Expand Tabs to Spaces For All Languages" (or shorter version)) - pushing this button would check ETTS
checkbox by all languages (I mean "All Languages")...

I will reopen this just in case, please close if I am just stupid...
Comment 6 Petr Dvorak 2008-08-01 22:08:28 UTC
*** Issue 142636 has been marked as a duplicate of this issue. ***
Comment 7 Vitezslav Stejskal 2008-08-04 09:50:31 UTC
Ok, I'll try to explain it better. The majority of users want to have the basic formatting settings (eg. expand tabs,
indent size, tab size, text limit) the same for all file types. If they change these settings they want to change them
for all file types. That's what the former 'Formatting' panel (in 6.1) in Tools-Options supported. And we want to
preserve this functionality.

Now, there are two types of files in the IDE - those that don't care about the formatting settings (eg. properties, xml,
css, etc) and those that add their own settings and provide their own customizers (eg. java, c++, ruby). There is no
problem with languages from the first group. They are controlled from the 'All Languages' customizer and there is no way
for them to override the basic settings.

The languages from the second group add more formatting settings and provide customizers for them. They should also have
a chance to override the basic formatting settings. In 6.1 we let those languages do what they wanted in regards to the
basic formatting settings, which lead to an inconsistent UI and some other problems. The idea for 6.5 was to use a
common basic settings customizer even for the languages that have their own customizers and to introduce a new
setting/checkbox, which will control whether the language overrides the basic formatting settings or not.

Is the direction we are heading to clearer now? I admit that we greatly underestimated the scale of the changes involved
in the introduction of per-project formatting settings and the overall consolidation of formatting settings in the IDE.
I'm CCing Ondra and Dusan to keep them in the loop.
Comment 8 Petr Dvorak 2008-08-04 10:02:16 UTC
> The idea for 6.5 was to use a common basic settings customizer even for the languages that have their own customizers
and ***to introduce a new setting/checkbox, which will control whether the language overrides the basic formatting
settings or not***.

OK, we are clear now - this was the information I was looking for. I was confused because the checkbox that indicates
that default settings are overridden was not present in the panels (it has to be in every languages' panel, right?) in
latest dev builds (30/07/2008).
Comment 9 Vitezslav Stejskal 2008-08-08 09:32:27 UTC
I'd like to make this an umbrella for other complaints that keep cropping up.
Comment 10 Vitezslav Stejskal 2008-08-08 09:33:33 UTC
*** Issue 141974 has been marked as a duplicate of this issue. ***
Comment 11 Vitezslav Stejskal 2008-08-08 09:34:44 UTC
*** Issue 141983 has been marked as a duplicate of this issue. ***
Comment 12 Jiri Prox 2008-08-19 16:59:59 UTC
*** Issue 144044 has been marked as a duplicate of this issue. ***
Comment 13 Vitezslav Stejskal 2008-08-20 10:26:13 UTC
I just pushed the changes to main. They were spread across many changesets, so I'm not going to link them here.